Flame seems pretty universally agreed as being the best damage type for dps.

hock damage is probably what I use more often than Flame damage on my mag characters, because of its aoe potential and the ease with which heavy attacks can be executed in content (which also has multiple target component). Also, concussion followed by off balance is significant for dps.

or perhaps Magic as its just easy to build with and to use.

Shock damage is my favorite, I still find it strange that sorcs dont have a shock single target ranged spammable ability.
It would be cool to make a shock only magsorc without having to rely on heavy attacks.

It terms of visuals, shock damage: overload+boundless storm, and then calling down lightning, it looks badass. In terms of sounds and animations, physical damage: killer's blade, executioner, steel tornado, the daggers from bound armaments when they strike...

mental damage, it's triggered by attempts "sneak" toggling, over an opponent, if you know what i mean.

When it comes to magical elemental damage, there is no better type than fire. The disgusting amount of pandering to it in this game really gets on my nerves. Shock and especially frost magic are completely underrepresented through damage skills and damage related sets, fire gets all of that and more because of engulfing flames and that new monster helmet, meaning group fire damage done is now at 14% more than other elements.

Here's another taste of how bad it is. Note that this is not including elemental sets that feature all frost, fire and shock but will include sets like ilambris and ice furnace since i don't think it's fair to not include them.

I will also be including damage skills which in my opinion can can be considered to be legitimately used as part of a dps rotation, or has at least some damage related niche. This won't include skills that deal a very small amount of damage as flavour such as a pet light attack or magma shell's damage aoe. They will be counted in general from every skill line in the game. These parts should be taken with a grain of salt since it's kind of hard to measure opinion. Additionally they will only be counted once unless the morphs are different magical damage types. Like ice comet for example. destruction staff skills, are counted as well. Adding 5 to every total.

Amount of fire monster helmets: 8
Amount of fire regular sets: 13
Amount of legitimate fire damage skills: 22 (17 without destro)

Amount of shock monster helmets: 2
Amount of shock regular sets: 6
Amount of legitimate shock damage skills: 12 (7 without destro)

Amount of frost monster helmets: 1
Amount of frost regular sets: 5
Amount of legitimate frost damage skills: 12 (7 without destro)

So using rough opinion, this shows what element gets more love than the other 2, in 2 ways.