Probably to complex and you now have two functions, now are you very sure you remember to update both 😺LootAllTheStuff wrote: »I've not played for that long (about a year) so I'm not sure about this, but I've seen some old posts that suggest the "Refine Multiple" wasn't always an option? If that's the case, then looping the rolls for each stack would make sense - it would be the easiest way to add the feature to existing code.
The other practical issue with doing it in a single pass is, if you generate more bonus items than the player has room for, which to you discard? I guess you could look at how many free slots there where, divide by 5, round down, and only run the calculation for that many stacks. That would look the same as looping, so who knows?
LootAllTheStuff wrote: »I've not played for that long (about a year) so I'm not sure about this, but I've seen some old posts that suggest the "Refine Multiple" wasn't always an option? If that's the case, then looping the rolls for each stack would make sense - it would be the easiest way to add the feature to existing code.
The other practical issue with doing it in a single pass is, if you generate more bonus items than the player has room for, which to you discard? I guess you could look at how many free slots there where, divide by 5, round down, and only run the calculation for that many stacks. That would look the same as looping, so who knows?