Patch breaks Guild History reading addons

GarnetFire17 · August 2019

Not Working:
Raffle Gold
Shiissu's History Scanner (Guild Tools)

Maybe working but annoying error messages pop up:
Advanced Member Tool Tip
Arkadius's Trade Tools

Philgo68 · August 2019

Yes, the API calls for retrieving guild history type information were changed in this release. These addons will all need adjustments to work.

Gythral · August 2019

add Tamriel Trade Centre to that list, as it does seem ZOS broke everything to do with trading!

silvermistktralasub17_ESO · August 2019

As a note on TTC, I was speaking with someone who had had TTC errors on only one guild. The fix for that was simple. He merely had to remove the saved variables for ttc and let it rebuild it, and then the error for that went away.

girlpoison · August 2019

For Raffle Gold:

Find the LUA file under, documents > Elder Scrolls Online > live > AddOns > Raffle Gold

Using Notepad++
Line 670: Replace 'RequestGuildHistoryCategoryNewest' with 'RequestMoreGuildHistoryCategoryEvents' (no quotes)

For errors created by Advanced Member Tool Tip & Arkadius's Trade Tools, install the No Thank You! add on and set LUA ERRORS > redirect lua error to: none to stop them from printing.

I am looking for someone to fix Raffle Gold Tally since that one seems to not work at all anymore.

sylviermoone · August 2019

girlpoison wrote: »

For Raffle Gold:

<snip>

For errors created by Advanced Member Tool Tip & Arkadius's Trade Tools, install the No Thank You! add on and set LUA ERRORS > redirect lua error to: none to stop them from printing.

<snip>

I know that error messages can be quite annoying, and if you're using addons that aren't updated frequently, suppressing the messages seems like a blessing.

The flip side of this, however, is that those error messages are incredibly helpful when developers are trying to track down what's causing an issue. Supplying a screenshot of those messages can significantly reduce the time it takes a developer to fix a problem.

"Your addon is broken, please fix" isn't a great way to get help. It's incredibly non-descriptive and offers no actionable information. However, "I'm having x issue while using your addon in x context. Here is a copy of the error message I received while doing x" is INCREDIBLY helpful and descriptive. These messages are even more useful if you've enabled the detailed reporting option in your error messages. When detailed reporting is turned on, the error messages will point to specific lines of code where the addon is having trouble. I completely understand that:

user:/AddOns/MasterMerchant/MasterMerchant.lua:2449: function expected instead of nil
stack traceback:
user:/AddOns/MasterMerchant/MasterMerchant.lua:2449: in function 'MasterMerchant:ScanStoresParallel'
|caaaaaa<Locals> self = tbl, doAlert = true, timeLimit = 1565594379, guildNum = 5, i = 1, guildID = 697, guildName = "The Auction House" </Locals>|r"

means nothing to most people, but for an addon dev, there is a wealth of information here.

TLDR: Yes, error messages are annoying, but if you want help from a developer with an issue, you need to leave them on.

*edit to add space for clarity

Dont_do_drugs · August 2019

Also the no thank you addon isnt maintained anymore as well and throws errors itself, as i heard.

girlpoison · August 2019

Dont_do_drugs wrote: »

Also the no thank you addon isnt maintained anymore as well and throws errors itself, as i heard.

Not if you turn off LUA errors

KappaKid83 · August 2019

Master Merchant also seems to be pretty off if completely not working, at least for me.

girlpoison · August 2019

KappaKid83 wrote: »

Master Merchant also seems to be pretty off if not completely not working, at least for me.

I've found that you have to run /mm missing frequently to keep it up to date. After /mm missing type /mm verbose 4 so it outputs to chat what it's doing - you can see the percentage of sales it scans every minute. Because add ons are limited to requesting 100 records every 30 seconds, if you have a high traffic trade guild it can take several hours to complete the scan. When done set /mm verbose 1 so it stops posting to chat.

KappaKid83 · August 2019

girlpoison wrote: »

KappaKid83 wrote: »

Master Merchant also seems to be pretty off if not completely not working, at least for me.

I've found that you have to run /mm missing frequently to keep it up to date. After /mm missing type /mm verbose 4 so it outputs to chat what it's doing - you can see the percentage of sales it scans every minute. Because add ons are limited to requesting 100 records every 30 seconds, if you have a high traffic trade guild it can take several hours to complete the scan. When done set /mm verbose 1 so it stops posting to chat.

@girlpoison thank you very much, I will try this tonight when I get home!

sylviermoone · August 2019

girlpoison wrote: »

KappaKid83 wrote: »

Master Merchant also seems to be pretty off if not completely not working, at least for me.

I've found that you have to run /mm missing frequently to keep it up to date. After /mm missing type /mm verbose 4 so it outputs to chat what it's doing - you can see the percentage of sales it scans every minute. Because add ons are limited to requesting 100 records every 30 seconds, if you have a high traffic trade guild it can take several hours to complete the scan. When done set /mm verbose 1 so it stops posting to chat.

1. You don't need to run /mm missing. The scans take a LONG time because of the restrictions ZOS has put on how data is received from the server. Just let it do its thing and chill. You can switch characters while MM receives data, just don't switch accounts. MM remembers where it is in the scan and will pick up where it left off upon switching toons.
2. I suggest leaving your verbose setting to 4, so that you can see that the addon is actually doing what it is supposed to do if you trust the programming. It will overall take LESS time to scan, because you won't be going back 10 days every time.

ListerJMC · August 2019

girlpoison wrote: »

For Raffle Gold:

Find the LUA file under, documents > Elder Scrolls Online > live > AddOns > Raffle Gold

Using Notepad++
Line 670: Replace 'RequestGuildHistoryCategoryNewest' with 'RequestMoreGuildHistoryCategoryEvents' (no quotes)

This worked for me, thank you so much!

hexnotic · August 2019

N/A

ListerJMC · August 2019

NaranjaIslands wrote: »

So is Raffle Gold not working after the patch?

It broke with the patch yes, but the fix that @girlpoison posted worked for me. If you do it while you're in-game, you'll have to log out and back in again for the change to take effect.

KappaKid83 · August 2019

@girlpoison using the /mm missing worked for me thank you! I ran it both days this weekend and I seem to be up to date with everything, thanks again!

thermatico · August 2019

Is anyone having problems with guild history today? I saw they turned it off on EU but can't find if they turned it off on NA or not.

In my Guild/History/Sales tab it only shows history since I logged in today. Any thing beyond that doesn't show up. I do not have the "Press E for more" option in the history / sales tab.

Draughluin1025 · August 2019

So I attempted the fix that @girlpoison posted. Did the changes in the LUA folder and whatnot, but now the addon is giving me the error message that I need to select a guild in order for it to run the raffle. However, when I select the drop down menu to select a guild it does not list any. It did not do this previously. It did do it prior to @girlpoison 's fix though.

Did it change that now only a true guild master can pull the raffle and not other officers? Been doing it for ages and only now came across this problem. Not sure what else to try, since I have all the same permissions as my GM. We started the guild together, but she's on the West Coast and most of our guild is EST. As a result, I run a lot of the paper work.

Any insights are greatly appreciated!

ListerJMC · August 2019

Draughluin1025 wrote: »

So I attempted the fix that @girlpoison posted. Did the changes in the LUA folder and whatnot, but now the addon is giving me the error message that I need to select a guild in order for it to run the raffle. However, when I select the drop down menu to select a guild it does not list any. It did not do this previously. It did do it prior to @girlpoison 's fix though.

Did it change that now only a true guild master can pull the raffle and not other officers? Been doing it for ages and only now came across this problem. Not sure what else to try, since I have all the same permissions as my GM. We started the guild together, but she's on the West Coast and most of our guild is EST. As a result, I run a lot of the paper work.

Any insights are greatly appreciated!

That function has been broken for a while. You need to change it via chat commands. The one for this is:

/rg set guild <GUILD_NAME> - Sets the "Guild" for Guild Bank Raffle (case sensitive)

Full list here: https://www.esoui.com/downloads/info1290-RaffleGold.html

Freezbeez · December 2019

Little update for the problem regarding the name of the guild for the Raffle Gold addon.

"rf" is changed to "rfg"

Enter in the chat bar exactly this by replacing the name of the guild with yours:

/rfg set guild <Comptoir de Bordeciel>