Suggested Fix to Guild Bank Stacking

Endridi · October 2016

Ok, so most of us know and loathe the guild bank's lack of a stacking system. Further, most of us know that this feature was removed because of an item duplication glitch involving multiple players modifying the guild bank simultaneously. This is an extremely common problem in threaded programming, one that is solved using mutually exclusive access and locks.

As a possible solution to this problem, I suggest the addition of a bank stacking feature which would "lock" the bank to everybody except the guild leader (as there can only be ONE guild leader). Clearly, this feature would only be available to the guild leader. That way the guild leader can then stack the items in the bank (with one click) without ZOS having to worry about anybody simultaneously modifying the bank at the same time, thus eliminating the possibility of a duplication. Then the bank could be unlocked and access restored to other guild members.

A good thing about this solution is that it doesn't require any changes to the way the way the items are fetched from the database, so it shouldn't require modifying any, or much, pre-existing code. This limits the chances of breaking already working code and makes the change very easy to undo should it prove to cause issues. It's at little bulky, but it's nothing compared to the horrible bandage of a fix we currently are dealing with. This feature could even be packaged tidily into a single stack button which would lock the bank, kick out other members currently accessing it, stack the items, and then unlock the bank.

Any response from ZOS on whether this would be a viable solution or whether any other real solution to the problem is in works would be greatly appreciated.

SHADOW2KK · October 2016

Roomba addon sorts that, has done for a long time

Mirelurk · October 2016

SHADOW2KK wrote: »

Roomba addon sorts that, has done for a long time

You can't use Roomba on guild bank if you have ESO+ unless you want to steal all the crafting mats.

Endridi · October 2016

Before ANYBODY else says add-on, please realize that I, and pretty much everybody else, realizes that plug-in exists. I am on a console, and this thread was meant for console users, in particular, since we cannot download and use add-ons.

SHADOW2KK · October 2016

Mirelurk wrote: »

SHADOW2KK wrote: »

Roomba addon sorts that, has done for a long time

You can't use Roomba on guild bank if you have ESO+ unless you want to steal all the crafting mats.

True

NeKryXe · November 2016

Mirelurk wrote: »

SHADOW2KK wrote: »

Roomba addon sorts that, has done for a long time

You can't use Roomba on guild bank if you have ESO+ unless you want to steal all the crafting mats.

even out of ESO+ Roomba is starting to fail. there are no recent updates and it gives lots and lots of UI Errors that forces us to close the game and restart again. we really need the guild bank to be fixed.

lately i always get this error:

user:/AddOns/Roomba/Roomba.lua:515: attempt to index a nil value
stack traceback:
user:/AddOns/Roomba/Roomba.lua:515: in function 'func'
EsoUI/Libraries/Globals/globalapi.lua:194: in function '(anonymous)'

i have no idea what it means.

silvereyes · November 2016

NeKryXe wrote: »

Mirelurk wrote: »

SHADOW2KK wrote: »

Roomba addon sorts that, has done for a long time

You can't use Roomba on guild bank if you have ESO+ unless you want to steal all the crafting mats.

even out of ESO+ Roomba is starting to fail. there are no recent updates and it gives lots and lots of UI Errors that forces us to close the game and restart again. we really need the guild bank to be fixed.

lately i always get this error:

user:/AddOns/Roomba/Roomba.lua:515: attempt to index a nil value
stack traceback:
user:/AddOns/Roomba/Roomba.lua:515: in function 'func'
EsoUI/Libraries/Globals/globalapi.lua:194: in function '(anonymous)'

i have no idea what it means.

Roomba has supported the Craft Bag ever since March 2016. If you have the latest version, your stacks should not go into the Craft Bag while stacking.

I also actively maintain Roomba and have never seen the errors you reference. If you could go submit a bug report over on the Roomba ESOUI.com page stating your Roomba version, what other addons you are using, and steps to reproduce, I'll make sure it gets fixed.

Ayantir · November 2016

Hello,

I'm the Roomba author.

NeKryXe wrote: »

lately i always get this error:

user:/AddOns/Roomba/Roomba.lua:515: attempt to index a nil value
stack traceback:
user:/AddOns/Roomba/Roomba.lua:515: in function 'func'
EsoUI/Libraries/Globals/globalapi.lua:194: in function '(anonymous)'

i have no idea what it means.

You are using an outdated version. Please update. (last one was released more than
one month ago).

Mirelurk wrote: »

SHADOW2KK wrote: »

Roomba addon sorts that, has done for a long time

You can't use Roomba on guild bank if you have ESO+ unless you want to steal all the crafting mats.

You are using an outdated version of the addon. Roomba is Crafting Bag compatible since March 2016. Please update.

For the original issue. First, addon is working on both Keyboard & Gamepad UI.

If you're on a console, I'm aware this solution cannot be applied.

Then for Guild Bank locking, few things.

Guildmaster is not always here. Guild Officiers neither. Stacking can be hard on certain guilds.

We don't have the confirmation that this duplication issue cannot be triggerred by only 1 people (if I remember well, all you had to do was to pull an item while Guild bank was stacking them).
Because each process can take few milliseconds or long seconds, by being a bit lucky, you can duplicate without any help thousnds of items alone. only with a little Lua script.

I understand that like this we'll know the name of the guilty, but if you manage to create 1,000,000 gold tremps, the time ZOS catch you , you'll have time to sell them to Guild Store and completly broke ESO economy. (It only require 20 seconds between duplication and mass selling at Guild Store).

sirinsidiator · November 2016

Ayantir wrote: »

Hello,

I'm the Roomba author.

NeKryXe wrote: »

lately i always get this error:

user:/AddOns/Roomba/Roomba.lua:515: attempt to index a nil value
stack traceback:
user:/AddOns/Roomba/Roomba.lua:515: in function 'func'
EsoUI/Libraries/Globals/globalapi.lua:194: in function '(anonymous)'

i have no idea what it means.

You are using an outdated version. Please update. (last one was released more than
one month ago).

Mirelurk wrote: »

SHADOW2KK wrote: »

Roomba addon sorts that, has done for a long time

You can't use Roomba on guild bank if you have ESO+ unless you want to steal all the crafting mats.

You are using an outdated version of the addon. Roomba is Crafting Bag compatible since March 2016. Please update.

For the original issue. First, addon is working on both Keyboard & Gamepad UI.

If you're on a console, I'm aware this solution cannot be applied.

Then for Guild Bank locking, few things.

Guildmaster is not always here. Guild Officiers neither. Stacking can be hard on certain guilds.

We don't have the confirmation that this duplication issue cannot be triggerred by only 1 people (if I remember well, all you had to do was to pull an item while Guild bank was stacking them).
Because each process can take few milliseconds or long seconds, by being a bit lucky, you can duplicate without any help thousnds of items alone. only with a little Lua script.

I understand that like this we'll know the name of the guilty, but if you manage to create 1,000,000 gold tremps, the time ZOS catch you , you'll have time to sell them to Guild Store and completly broke ESO economy. (It only require 20 seconds between duplication and mass selling at Guild Store).

You can't expect us to do such mundane tasks as keeping our addons up to date or report bugs. There are complaints to be written and besides that, a friend of a guildmates dog said that there is no new version of ROOMBA and that it steals items, so it has to be true! No way that the author actually knows what he is talking about.

NeKryXe · November 2016

Ayantir wrote: »

Hello,

I'm the Roomba author.

NeKryXe wrote: »

lately i always get this error:

user:/AddOns/Roomba/Roomba.lua:515: attempt to index a nil value
stack traceback:
user:/AddOns/Roomba/Roomba.lua:515: in function 'func'
EsoUI/Libraries/Globals/globalapi.lua:194: in function '(anonymous)'

i have no idea what it means.

You are using an outdated version. Please update. (last one was released more than
one month ago).

i'm using the last version 2.6 09/20/16, but it's still marked as "out of date" on my game. like probably all players, i've been using Roomba for ages without any problem, without Roomba i wouldn't even use the guild bank

...but since the last patch i started to get a few difficulties to run it and UI errors like the one i shared. it might be an addon conflict, but i don't use many. i'll try to disable the other addons if the error persists. thank you for your reply