It is tough to make money crafting because so many guilds do free crafting for members. There are so many good dropped sets for armor and weapons that probably isn't a good market. I did okay selling low level food and beverages simply because so few people were offering them, but that has changed some. Still I would guess your best bet for making gold crafting would be with provisioning.
If making gold is your goal though selling the materials to other crafters will probably make more gold.

This is all just my personal experience and I have got a lot of things wrong in this game so...

Alchemy

Best to level all professions with your character if you can. Even if you don't want to invest any skill points into crafting skills at the start All professions won't be very profitable until you have near max rank in them or researched a good number of traits for Blacksmithing, Clothing, and Woodworking

At rank 50, Alchemy is probably still the best and most reliable crafting profession. People will always need certain types of potions in large quantities. But you can also just farm and sell the flowers instead without having any ranks in Alchemy. You might want to have a high rank in Alchemy anyway though for the "Medicinal Use" passive.
Alchemy writs (=daily crafting quests) will give you a few extra ingredients every day if you do them.

Blacksmithing, Clothing, and Woodworking can be ok if you have Nirnhoned and/or many traits researched on a lot of different items. There's still people who are looking for a crafter that can create specific set items for them, and many of them are willing to pay you quite for that. Researching traits will take a while though before you can craft some of the best sets (research good traits first if you can. For armor: Nirnhoned [very expensive to research at the the start but it's the best trait on armor right now], Infused, Reinforced, Divines; Exploration and Training are nice for low level characters but not for veteran gear; Impenetrable and Well-Fitted are less popular right now; always research Sturdy last ^^ For weapons: Sharpened and Precise are probably the most popular; Training for low level characters).
Equippable crafting writs may give you legendary upgrade materials but they consume a lot of materials so not many people do them on a daily basis.

Provisioning is good right now because of the Psijic Ambrosia recipe parts you may get when you complete a provisioning writ. You can also get purple ingredients and rare recipes from writs if you're lucky. Purple food sells for pretty low prices; you can sell ingredients you get from provisioning writs and hirelings as well, but the profits aren't huge.
You might want to have a high rank in Provisioning in any case for the "Gourmand" and the "Connoisseur" passives that make any buff food and drink you use (including the XP booster drink Psijic Ambrosia) last longer.

All 5 types of hirelings (Enchanting, Provisioning, Blacksmithing, Clothing, Woodworking) are nice to have since they may give you something valuable for just logging in The rewards add up if you have several characters with hirelings (but the daily relogging can also become annoying if you have too many characters you need to log in every day)

GaldorP wrote: »

Best to level all professions with your character if you can. Even if you don't want to invest any skill points into crafting skills at the start All professions won't be very profitable until you have near max rank in them or researched a good number of traits for Blacksmithing, Clothing, and Woodworking

At rank 50, Alchemy is probably still the best and most reliable crafting profession. People will always need certain types of potions in large quantities. But you can also just farm and sell the flowers instead without having any ranks in Alchemy. You might want to have a high rank in Alchemy anyway though for the "Medicinal Use" passive.
Alchemy writs (=daily crafting quests) will give you a few extra ingredients every day if you do them.

Blacksmithing, Clothing, and Woodworking can be ok if you have Nirnhoned and/or many traits researched on a lot of different items. There's still people who are looking for a crafter that can create specific set items for them, and many of them are willing to pay you quite for that. Researching traits will take a while though before you can craft some of the best sets (research good traits first if you can. For armor: Nirnhoned [very expensive to research at the the start but it's the best trait on armor right now], Infused, Reinforced, Divines; Exploration and Training are nice for low level characters but not for veteran gear; Impenetrable and Well-Fitted are less popular right now; always research Sturdy last ^^ For weapons: Sharpened and Precise are probably the most popular; Training for low level characters).
Equippable crafting writs may give you legendary upgrade materials but they consume a lot of materials so not many people do them on a daily basis.

Provisioning is good right now because of the Psijic Ambrosia recipe parts you may get when you complete a provisioning writ. You can also get purple ingredients and rare recipes from writs if you're lucky. Purple food sells for pretty low prices; you can sell ingredients you get from provisioning writs and hirelings as well, but the profits aren't huge.
You might want to have a high rank in Provisioning in any case for the "Gourmand" and the "Connoisseur" passives that make any buff food and drink you use (including the XP booster drink Psijic Ambrosia) last longer.

All 5 types of hirelings (Enchanting, Provisioning, Blacksmithing, Clothing, Woodworking) are nice to have since they may give you something valuable for just logging in The rewards add up if you have several characters with hirelings (but the daily relogging can also become annoying if you have too many characters you need to log in every day)

Correct. Alchemy, and only because the materials are time consuming to collect.