ZrMiniMap causing group lag when new member is added

scratchnsniff · June 2014

Not sure if anyone knows this, but I was having major lag issues whenever a new member was added to a group in the cryodiil.

I found when i disabled the Zrminimap addon, the lag went away.

Hopefully the addon can be fixed. Or do you think this is an issue with the server?

superkev · June 2014

Wow nice catch. Spread the word on that one removing zrminimap solved my lag issues in cyrodil. Huge info. Thank you.

kimboh · June 2014

Yep, I tried Zrmm and noticed a lot of lag, disabled it and lag went away.

zgrssd · June 2014

scratchnsniff wrote: »

Hopefully the addon can be fixed. Or do you think this is an issue with the server?

Propably 50/50. Same as with the Esc bug from addons.

Could you check if you have the issue when you turn all addons off? Most people with similar issues said they "turned all addons off".
It might be two bugs that just look similar. Or it might actually be in the game, and somehow be solved by one addon (but only as long as ZRMM is not running too).
The more data we get, the better.

onlinegamer1 · June 2014

I found this in the LUA file on line 494:

-- check and update if group member pin
local unitTag = v.m_Pin:GetUnitTag()
if string.find(unitTag, "group") then
-- must be a group member
if GetUnitName(unitTag) ~= playerName then
-- hey it's not ourselves either...
if GetUnitZone(unitTag) == playerZone then
unitX, unitY = GetMapPlayerPosition(unitTag)
-- we also want to force the control to not be hidden otherwise user would have to open the map first
v:SetHidden(false)
v.hidePin = false
end
end
end

Gonna try commenting these lines out tonight when I get home to see if that helps the lag.

Phinix1 · June 2014

I have actually switched temporarily to the Lightweight Minimap by Shinni due to this problem, which can actually cause the game to crash. Worse, if you are still in a group when you try to log back in, ZrMM can cause you to crash before the game even loads until you disable it.

I just parked LMM in the same spot I had ZrMM and it is basically the same. Main difference is you have to set the zoom level by slash commands and the clicking sound when you open a map (don't even notice it really), and sometimes you have to open the map and close it to get the zoom level right after zoning.

The map pins are also a little bigger and can't be changed yet, but overall it is less laggy in general and doesn't have this group crash bug.

scratchnsniff · June 2014

AlienDiplomat wrote: »

I have actually switched temporarily to the Lightweight Minimap by Shinni due to this problem, which can actually cause the game to crash. Worse, if you are still in a group when you try to log back in, ZrMM can cause you to crash before the game even loads until you disable it.

I just parked LMM in the same spot I had ZrMM and it is basically the same. Main difference is you have to set the zoom level by slash commands and the clicking sound when you open a map (don't even notice it really), and sometimes you have to open the map and close it to get the zoom level right after zoning.

The map pins are also a little bigger and can't be changed yet, but overall it is less laggy in general and doesn't have this group crash bug.

I did some experimenting and found the ZR MM with Boarders causes NO lag in the cryodiil. It was modified by someone different so I am not sure if they changed the code or something.

I haven't had an issues since I switched.

Tess_Phyreforge · June 2014

because of the lag ZR mini map caused I switch to LUI by LoPony it has a mini map plus more.

zgrssd · June 2014

onlinegamer1 wrote: »

I found this in the LUA file on line 494:

-- check and update if group member pin
local unitTag = v.m_Pin:GetUnitTag()
if string.find(unitTag, "group") then
-- must be a group member
if GetUnitName(unitTag) ~= playerName then
-- hey it's not ourselves either...
if GetUnitZone(unitTag) == playerZone then
unitX, unitY = GetMapPlayerPosition(unitTag)
-- we also want to force the control to not be hidden otherwise user would have to open the map first
v:SetHidden(false)
v.hidePin = false
end
end
end

Gonna try commenting these lines out tonight when I get home to see if that helps the lag.

It could be a race condition of the unusual sort.
Basically I think that when this code runs the variable behind GetMapPlayerPosition is not yet set. Hence GetMapPlayerPostion turns into a blocking call (till the data is supplied by the Network thread), locking up the UI thread as a result.

The game does seem to use a classical 3 threaded MMO Design (UI/main, Network, Blob-loader).