DragonHold update - AddOn errors (<function called from insecure> e.g.)

Baertram

Hey there,

I just wanted to tell you that ZOs has changed some secure function code and some addons might produce error messages like "Tried to call <functio name> from insecure" as Dragonhold hits live.
There is not shown any particular addon name in that error message then
If you experience this try to disable your addons having to do with Crafting or Inventories first and see if it's gone afterwards.
Check these addon comments over at www.esoui.com then or check the forums at www.esoui.com first before posting several threads here which are not read constantly.
Some addons got a "sticky post" at the top of the comments where you can find actual new and beta versions. Try if posted betas fix erros for you (they need to be installed manually and cannot be installed via Minion! Here is a howot manually install an addon: https://www.esoui.com/forums/faq.php?faq=new_faq_item#faq_install)

I hope there are not that much errors happening though. But if so please stay calm and just wait for an update of addons. Check regulalry via Minion addon manager e.g..
If you got any feedback and way to reproduce the errors post them at esoui.com at the related addon comments please!

Thanks for your support.
Baertram

Maggi12

what is the root of the problem?
i am trying to fix FCO item saver errors... or errors caused by that addon.. i cant literally bank my items!!

Baertram

Update the addon, there shouldn't be any errors then. If there still are disable other addons and try again please. If you can find out a constellation of addons which do not work together with FCOIS:
As I wrote: please write in the addon comments at www.esoui.com.ycsnnot check both forums constantly, sorry. Thank you.

The root is that ZOs changed their code and literally all inventory hooks which were made in the past need to be rechecked if the code now is insecure.
This might happen only with one addon enabled but also if several addons work together.

kringled_1

This is affecting a couple of different inventory grid style add-ons, one of which I've used for a long time, one of which I just tried. Any pointers to an up-to-date add-on that accomplishes the same thing?

Maggi12

I have made a big cleaning of my addons from commonly used libs like stub, addon-menu, common-menu.
if addon has in its package the mentiones libs above, i was remove them from package and its manifest file.
The first time everything worked fine, i was able to use inventory items, and deposit them to bank. But after some time *** continues to happen again. Where is changelog from ZOS for addon creators???

Dolgubon

Maggi12 wrote: »

I have made a big cleaning of my addons from commonly used libs like stub, addon-menu, common-menu.
if addon has in its package the mentiones libs above, i was remove them from package and its manifest file.
The first time everything worked fine, i was able to use inventory items, and deposit them to bank. But after some time *** continues to happen again. Where is changelog from ZOS for addon creators???

It's stickied in this forum. Usually there isn't much changed for add-ons from the first pts patch

Baertram

Relax. You just need to wait. Both of you :-) Like after each major update. This time it may be some weeks longer, depending on the addons affected and the changes ZOs did in the background. Maybe I'm wrong and it will be even fixed within some days.

There are existing addons which need to be adopted to work with other addons together so there are no isnecure messages thrown anymore.
Not sure if the devs of these addons are still active but if they are write to their comments page on www.esoui.com and tell them how to get the error so they are able to reproduce and fix them.

And if banking is not possible with addons enabled then just disable ALL addons and enjoy the game without them for a while. This normally will make you cry and see how much addons help and what value and time and effort the devs invest for themselves and you to have a nicer game experience
If you already know that e.g. FCOItemSaver in combination with other addons currently throw error messages at the banking, disable FCOIS then as you go to the bank.
-> AddonSelector is nice addon to build profiles and to load them with 2 clicks!

As ZOs changed some basics which I cannot even explain to you: Time will fix this. Addons need to be tested together. Ppl need time to test and find errors. We need information how to rebuild the errors (messages like "I get an error" do not help here).

rumple9

same - I cannot deposit anything in bank

Major_Lag

On my setup, I can very reliably reproduce the error if both of the following conditions are met:
1. FCOIS is enabled in the addon menu, and
2. I try to deposit any item in the bank without opening the inventory menu first.

So there are 2 workarounds for the time being: either disable FCOIS, and/or remember to open the inventory before trying to do anything at a bank.

Baertram

On my setup, I can very reliably reproduce the error if both of the following conditions are met:
1. FCOIS is enabled in the addon menu, and

What you did NOT tell here is:
If you ONLY enable FCOIS this will work just fine WITHOUT any error messages.
So this is not FCOIS causing it but another addon like Inventory Grid View or GridList.
FCOIS only triggers code in the other addon which then fails/get's insecure.

Or are you able to get the same with ONLY FCOItemSaver enabled?
If so please provide me steps how to reproduce this and I'll hape a look on thursday as I get back.
-> btw: I have several answers in the FCOIS comments already which say "Nope" ;-)

Please check the sticky post on www.esoui.com -> FCOItemSaver comments. I've updated it with some information below the light blue heading.

The workarounds can be enhanced by this entry then:
Please disable addons changing inventory related stuff like Inventory Grid view and/or update GridList and PerfectPixel addons (there was an update recently).
Try if this fixes it. If not, disable other addons related to crafting inventory or inventory / bank management and see which one causes the problem, if FCOIS is still enabled.
This is effort, yes. But it will most likely help, if you post the error to THIS addon comments then, to fix it for us all.

And about "Same here" posts:
This does not help at all, sorry The only thing it does is increasing your post counter

taiyoukei

Oh, this is why my bank just up and stopped working.
Disabled Inventory Grid View for now since it was causing the problems.

Major_Lag

Baertram wrote: »

What you did NOT tell here is:
If you ONLY enable FCOIS this will work just fine WITHOUT any error messages.
So this is not FCOIS causing it but another addon like Inventory Grid View or GridList.
FCOIS only triggers code in the other addon which then fails/get's insecure.

Nowhere did I claim that the problem is with FCOIS' code.
It is, however, an undisputable fact that disabling FCOIS (and only FCOIS) makes the problem go away on my installation.

I have over 30 addons, about half a dozen of which affect the way the inventory/bank list is displayed.
I've already wasted way too much of my limited playing time trying to make the game at all playable because of the UI errors; I'd much rather just disable FCOIS until the problem is resolved - especially since at this time, I don't really need FCOIS, and can very much do away without its functionality.

While I fully I understand that technically, the fault does not lie with the author of FCOIS (that is: you), the fact remains that FCOIS currently causes other addons to break - and those addons also work perfectly fine on their own.
FCOIS also works perfectly fine on its own. See what I'm getting at here?

rumple9

The problem is caused by libfilters3.0 - if you disable it you can deposit things in the bank

Major_Lag

rumple9 wrote: »

The problem is caused by libfilters3.0 - if you disable it you can deposit things in the bank

Are you sure about that?
libfilters is a dependency of FCOIS; disabling libfilters causes FCOIS to also become disabled... and we're back to square one.

rumple9

yes definately Libfilters3

Major_Lag

Don't think you understood my point.
Disabling libfilters causes FCOIS to become automatically disabled (in fact, it's impossible to re-enable it until you first re-enable libfilters).

We've already established (above) that disabling FCOIS causes the problem to disappear.

Therefore, the conclusion that "libfilters is responsible for the error" is flawed and without rational basis.
Or can you perhaps point out which part of libfilters is responsible? No? Didn't think so.

Baertram

The problems relate to any inventory changing addons which in some way make the Zos code insecure.
Even FCOIs works if you open the inventory FIRST before going to a bank. UIntil next reloadui you got no error message then (in most caes).

So far known problems are with
Inventory Grid View
Grid List (patched version was released -> And ZOs told the dev there are problems with addons which update the inventories->could make them insecure. That's why the changelog of GridList currently says to "Change a filter to update the inventory!")
CraftBagExtended
FCOItemSaver
AdvancedFilters UPDATED

So it's not ONLY LibFilters but it could have to do with the inventopry updates which need to be done was well by LibFilters if the filters got applied (e.g. your bank filters of FCOItemSaver, or the Subfilterbars of AdvancedFilters).

Not sure how to fix this, maybe ZOs needs to, maybe we find a way. Hopefully we do first :-p

Baertram

Got an info from ZOs about the error messages:

It's because the security of the handlers comes from the security of the function plus the security level when they are set (this second part is new). So when an addon tells the inventory to build a bunch of inventory slots, all those handlers are insecure and cannot call private functions. The next patch will change that so those handlers will be secure which will make these errors go away.

The explanation more in detail was finished with this information:

Things that change the bag that is shown by calling UpdateList on the inventory for example.

If you open the inventory first then the stock UI will make all the slots securely. Then when the addon does it they'll already be there to use.

So this is why opening the inv first made the errors stop for some time.

As the addons, and especially filter addons using LibFilters, use an update function to show/update the inventory rows this shoudl relate to all of the addons like AdvancedFilters, FCOItemSaver, Inventory Grid List and others which add marker icons to the inventory rows (maybe even Craftstore or Alphagear).

I hope this will fix all the cannot pickup/deposit stuff as well or we need to see further after that patch then.

daim

Ugh couldn't remember how bad the stock inventory was in the game now that I had to disable Inventory Grid !

I hope ZOS fixes this fast, I hate to log in at the moment and try to enjoy playing and with the stock inventory I can't say it's an enjoyment..

Baertram

Try out GridList, it's the same as Inventory Grid View and works currently.
You only need change a filter (like switch from 1 to another inventory category) to update the list as the UpdateList function of ZOs (see my post above) is currently raising the insecure calls.

Fandriil

TY Baertram for this news. It's a pain to work with the normal inventory in list form.

Baertram

ZOs has patched this and the errors should be gone since Monday 4th November.