DenverRalphy wrote: »I see that this addon has reappeared under a different author's name.
Different autho taking up the reignsr? Or same person, just a new name?
Suspicious at the very least. I won't download it until its proven to be legit.DenverRalphy wrote: »(...) Different autho taking up the reignsr? Or same person, just a new name?
No, in my honest opinion it is not!
And even if the license says you can use the code, you should not totally copy it and then rename LibQRCode to some DataExtractor variable and silently include that into your addon.
I do not even see the reason behind that: Why not simply adding the LibQRCode as dependency so it automatically installs with the addon, and then you can use that lib and automatically benefit if any error fix of that lib is done by someone else.
Instead he copies the total code, renames it, changes a few lines for whatever not understandable reason.
Well the lib is included with it's licensing text but it is nowhere mentioned at the addon description that this was done, any why.
You cannot really do anything malicious with it as it only generates a QRcode and then you can scan that with a smartphone e.g. But either way, providing proper credit at the addon description is a must-have if you incldue 99% of other developers code! Fail-again
allochthons wrote: »I reported the re-uploaded versions on bethesda.net, but then read that they didn't contain any malicious code over on ESOUI, and felt pretty bad about reporting. And today, there was someone in one of my trading guilds celebrating the return of this add-on.
I'm glad it's gone again. Even if it's safe, I don't trust it, and the idea that malicious code could be added later definitely occurred to me. Especially since we didn't know if the new uploader was just the old one with a new account.
I AM sad that the add-ons we have now are all either PC or XBox prices, since I'm PS, and some of the prices are dramatically different. And I'm noticing people just going blindly with what the add-on says, instead of doing price checking of their own. Oh, well. So it goes on the guild traders. If we ever get cross-play (which I don't actually want, but am happy to be proven wrong), the economies will merge anyway.
Hmm. Okay. I thought that was true, but the person in my large trading guild today who was excited this add-on was back was saying it was specifically PS prices. It's good to know that's incorrect.It's always been just Xbox prices. Afaik, market tracker used Xbox prices as well. They just weren't upfront about it.
allochthons wrote: »Hmm. Okay. I thought that was true, but the person in my large trading guild today who was excited this add-on was back was saying it was specifically PS prices. It's good to know that's incorrect.It's always been just Xbox prices. Afaik, market tracker used Xbox prices as well. They just weren't upfront about it.
Thanks.
I've installed the TSC add-on just for a price reference (even if the add-on has only the data from the NA Xbox server) and I also check traders in major cities to have some more pointers. Believe it or not but some itens prices are pretty similar across all servers and platforms even if the population may differ.allochthons wrote: »(...) I AM sad that the add-ons we have now are all either PC or XBox prices, since I'm PS, and some of the prices are dramatically different.(...)